<html>
<head><meta charset="utf-8"><title>Reviewing policy for new unstable library features? · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html">Reviewing policy for new unstable library features?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="208722981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208722981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208722981">(Sep 01 2020 at 17:50)</a>:</h4>
<p>I have <a href="https://github.com/rust-lang/rust/issues/76204">#76204</a> on me to review, and it adds new unstable APIs.  As unstable I know it doesn't need a full libs FCP, but is there a suggestion of how much of an FYI to give?  Should I avoid r+'ing until at least one libs member says "ok, that seems reasonable"?</p>
<p>(The request in the issue makes sense to me, it's a thing that's been valuable in the iterator implementation for years now, I'd like to have it for the <code>Try</code> implementation, and ecstatic-morse would also like it for graph traversals (like the OP) in rust.  But none of those are an explicit libs ok...)</p>



<a name="208723161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208723161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208723161">(Sep 01 2020 at 17:52)</a>:</h4>
<p>FWIW one of my PRs got approved with only one reviewer <a href="https://github.com/rust-lang/rust/pull/72310">https://github.com/rust-lang/rust/pull/72310</a></p>



<a name="208723202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208723202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208723202">(Sep 01 2020 at 17:52)</a>:</h4>
<p>although <span class="user-mention silent" data-user-id="119235">David Tolnay</span> is very well known for libs work so maybe not a 1-1 comparison ^^</p>



<a name="208724402"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208724402" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208724402">(Sep 01 2020 at 18:02)</a>:</h4>
<p>Yes, unstable API additions need only one libs team "seems good," and not necessarily of the exact API (e.g., a comment on an issue is usually sufficient)</p>



<a name="208834118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208834118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208834118">(Sep 02 2020 at 14:41)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> I can comment on that patch if you want, I have some suggestions.</p>



<a name="208834371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208834371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208834371">(Sep 02 2020 at 14:42)</a>:</h4>
<p>if you have api suggestions go for it :) but i don't think the implementation is worth worrying about since it's on nightly without much use</p>



<a name="208835423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208835423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208835423">(Sep 02 2020 at 14:50)</a>:</h4>
<p>Nah, just some comments on the documentation and type signature.</p>



<a name="208835508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Reviewing%20policy%20for%20new%20unstable%20library%20features%3F/near/208835508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Reviewing.20policy.20for.20new.20unstable.20library.20features.3F.html#208835508">(Sep 02 2020 at 14:50)</a>:</h4>
<p>I don't know why but I do seemed to comment quite a lot on documentations, including misdreavus ones.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>